fix: password reset sending multiple requests #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
force-pushed
the
mxyng/minor-ui-fixes
branch
from
492e941
to
00ef53e
Compare
jmorganca
reviewed
Sep 6, 2022
mxyng
force-pushed
the
mxyng/minor-ui-fixes
branch
from
00ef53e
to
7622026
Compare
BruceMacD
reviewed
Sep 7, 2022
| @@ -13,6 +13,7 @@ export default function PasswordReset() { | |||
| const [submitted, setSubmitted] = useState(false) | |||
|
|
|||
| async function onSubmit(e) { | |||
| setSubmitted(true) | |||
There was a problem hiding this comment.
You may want to set this back to false on error so the user can try again.
There was a problem hiding this comment.
Good call out though but the UI doesn't currently branch on errors. The error state is never set to a non-empty value so I've removed it
mxyng
force-pushed
the
mxyng/minor-ui-fixes
branch
from
7622026
to
a74b569
Compare
mxyng
force-pushed
the
mxyng/minor-ui-fixes
branch
from
a74b569
to
fbc1e44
Compare
BruceMacD
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set
submittedstate as soon as the submit button is pressed rather than after the request returns.Also some minor UI issues like
Resolves #3114