feat: SCIM list provider users #3379
Conversation
BruceMacD
requested review from
ssoroka,
technovangelist,
dnephin,
jmorganca,
pdevine and
mchiang0610
as code owners
- add SCIM list users endpoint - add SCIM role
BruceMacD
force-pushed
the
brucemacd/scim-users-get
branch
from
bd75fea
to
40c966e
Compare
| @@ -64,7 +64,7 @@ func AssignIdentityToGroups(tx GormTxn, user *models.Identity, provider *models. | |||
| } | |||
| addIDs = append(addIDs, item) | |||
| } | |||
| if rows.Err() != nil { | |||
| if err := rows.Err(); err != nil { | |||
There was a problem hiding this comment.
Looks like this would have returned nil previously, which doesnt seem intentional.
|
|
||
| if p != nil { | ||
| // apply scim parameters | ||
| if p.Count != 0 { |
There was a problem hiding this comment.
These are similar to our pagination, but slightly more complicated. Our pagination only allows set page sizes, but SCIM requires a "start index" which offsets the results.
| @@ -105,7 +105,7 @@ func AssignIdentityToGroups(tx GormTxn, user *models.Identity, provider *models. | |||
| } | |||
| ids = append(ids, item) | |||
| } | |||
| if rows.Err() != nil { | |||
| if err := rows.Err(); err != nil { | |||
| ADD COLUMN IF NOT EXISTS given_name text, | ||
| ADD COLUMN IF NOT EXISTS family_name text, | ||
| ADD COLUMN IF NOT EXISTS active boolean DEFAULT true; |
There was a problem hiding this comment.
These aren't being used yet, but I guess the next PR will include an update endpoint where these will be set, is that right?
There was a problem hiding this comment.
Yeah, control of these will be set through the SCIM create user endpoint, I'll make some updates to the just-in-time logic too. These are required fields for the SCIM spec.
| err := CreateProvider(tx, provider) | ||
| assert.NilError(t, err) | ||
|
|
||
| pu := createTestProviderUser(t, tx, provider, "david@example.com") |
There was a problem hiding this comment.
Not a blocker, but I've been trying to include a few records that I expect not to match the query in most of the tests for List operations. Something like same email different provider.
- add SCIM list users endpoint - add SCIM role
Summary
This change adds the necessary logic for a SCIM identity provider to list the users it has associated with it.
It does not include the changes necessary to create an access key for an identity provider (which this functionality will rely on) so the code path can't be accessed yet.
Checklist
Related Issues
Part of #3378