Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces gin with echo using the x/echox package.
Some note worthy changes.
echo.Context
doesn't implementcontext.Context
so the issue resolved bygin.Engine.ContextWithFallback
is not an issue asecho.Context.Request().Context()
must be provided directly instead.The removal of the error handling middleware. Talking with @jnschaeffer, there seemed to be an issue with oapi-codegen's gin middleware not handling errors as expected, which doesn't appear to be an issue with the way echo errors are handled.