Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap gin for echo #144

Merged
merged 1 commit into from
Apr 18, 2023
Merged

swap gin for echo #144

merged 1 commit into from
Apr 18, 2023

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Apr 18, 2023

This replaces gin with echo using the x/echox package.

Some note worthy changes.

echo.Context doesn't implement context.Context so the issue resolved by gin.Engine.ContextWithFallback is not an issue as echo.Context.Request().Context() must be provided directly instead.

The removal of the error handling middleware. Talking with @jnschaeffer, there seemed to be an issue with oapi-codegen's gin middleware not handling errors as expected, which doesn't appear to be an issue with the way echo errors are handled.

Signed-off-by: Mike Mason <mimason@equinix.com>
@mikemrm mikemrm marked this pull request as ready for review April 18, 2023 17:23
@mikemrm mikemrm requested review from a team as code owners April 18, 2023 17:23
@mikemrm mikemrm merged commit e950893 into infratographer:main Apr 18, 2023
@mikemrm mikemrm deleted the update-echo-x branch April 18, 2023 20:55
nicolerenee added a commit that referenced this pull request Apr 21, 2023
* chore: Update goreleaser to use an include with our base config (#142)

Signed-off-by: GitHub <noreply@github.com>

* add oidc discovery endpoint (#138)

* add oidc discovery endpoint

Adds /.well-known/openid-configuration endpoint.

Issuer is provided from the config.OIDC.Issuer field.

The remaining fields are generated from the http request.

Signed-off-by: Mike Mason <mimason@equinix.com>

* cleanup buildURL function and add tests

Signed-off-by: Mike Mason <mimason@equinix.com>

---------

Signed-off-by: Mike Mason <mimason@equinix.com>

* swap gin for echo (#144)

Signed-off-by: Mike Mason <mimason@equinix.com>

* fix(deps): update module github.com/getkin/kin-openapi to v0.116.0 (#145)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* use existing jwks information instead of fetching from self (#146)

Corrects an issue an issue of depending on jwks endpoint which isn't
available yet as the service hasn't been started.

Instead we should've used the jwt signing details already known.

Signed-off-by: Mike Mason <mimason@equinix.com>

* oidc use issuer as base instead of current request (#147)

Use the issuer as the base url instead of generating a relative url
based on the current request to ensure the url is rendered properly.

Signed-off-by: Mike Mason <mimason@equinix.com>

* just override args instead of command

Signed-off-by: Mike Mason <mimason@equinix.com>

---------

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
Co-authored-by: Nicole Hubbard <code@nicole.dev>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants