oidc use issuer as base instead of current request #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the issuer as the base url instead of generating a relative url based on the current request to ensure the url is rendered properly. Signed-off-by: Mike Mason <mimason@equinix.com>
JAORMX
previously approved these changes
Apr 21, 2023
JAORMX
approved these changes
Apr 21, 2023
nicolerenee
added a commit
that referenced
this pull request
Apr 21, 2023
* chore: Update goreleaser to use an include with our base config (#142) Signed-off-by: GitHub <noreply@github.com> * add oidc discovery endpoint (#138) * add oidc discovery endpoint Adds /.well-known/openid-configuration endpoint. Issuer is provided from the config.OIDC.Issuer field. The remaining fields are generated from the http request. Signed-off-by: Mike Mason <mimason@equinix.com> * cleanup buildURL function and add tests Signed-off-by: Mike Mason <mimason@equinix.com> --------- Signed-off-by: Mike Mason <mimason@equinix.com> * swap gin for echo (#144) Signed-off-by: Mike Mason <mimason@equinix.com> * fix(deps): update module github.com/getkin/kin-openapi to v0.116.0 (#145) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * use existing jwks information instead of fetching from self (#146) Corrects an issue an issue of depending on jwks endpoint which isn't available yet as the service hasn't been started. Instead we should've used the jwt signing details already known. Signed-off-by: Mike Mason <mimason@equinix.com> * oidc use issuer as base instead of current request (#147) Use the issuer as the base url instead of generating a relative url based on the current request to ensure the url is rendered properly. Signed-off-by: Mike Mason <mimason@equinix.com> * just override args instead of command Signed-off-by: Mike Mason <mimason@equinix.com> --------- Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Mike Mason <mimason@equinix.com> Co-authored-by: Nicole Hubbard <code@nicole.dev> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the issuer as the base url instead of generating a relative url based on the current request to ensure the url is rendered properly.