Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test releases #151

Merged
merged 7 commits into from
Apr 21, 2023
Merged

Test releases #151

merged 7 commits into from
Apr 21, 2023

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Apr 21, 2023

No description provided.

nicolerenee and others added 7 commits April 17, 2023 11:56
* add oidc discovery endpoint

Adds /.well-known/openid-configuration endpoint.

Issuer is provided from the config.OIDC.Issuer field.

The remaining fields are generated from the http request.

Signed-off-by: Mike Mason <mimason@equinix.com>

* cleanup buildURL function and add tests

Signed-off-by: Mike Mason <mimason@equinix.com>

---------

Signed-off-by: Mike Mason <mimason@equinix.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Corrects an issue an issue of depending on jwks endpoint which isn't
available yet as the service hasn't been started.

Instead we should've used the jwt signing details already known.

Signed-off-by: Mike Mason <mimason@equinix.com>
Use the issuer as the base url instead of generating a relative url
based on the current request to ensure the url is rendered properly.

Signed-off-by: Mike Mason <mimason@equinix.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
Copy link
Member

@nicolerenee nicolerenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport away

@mikemrm mikemrm marked this pull request as ready for review April 21, 2023 15:01
@mikemrm mikemrm requested review from a team as code owners April 21, 2023 15:01
@nicolerenee nicolerenee merged commit 353cf6e into releases/2023.04 Apr 21, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants