Remove in-memory storage engine, refactor config logic #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By convention, Infratographer CRDB configs should be a top-level config item. In reconfiguring this, a number of other things shook out including no longer needing (or necessarily even wanting) a separate in-memory storage engine. The dev container supports a database now and we can just create CRDB test servers as needed for testing. This commit refactors the storage package to take a crdbx config directly and defines migrations, tracing, and database seeding as options on the storage engine. Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
jnschaeffer
force-pushed
the
move-crdb-config
branch
from
e8f67c8
to
33d08e5
Compare
adammohammed
reviewed
Mar 2, 2023
internal/storage/crdb.go
Outdated
Comment on lines
55
to
56
| func (eng *engine) Shutdown() error { | ||
| return eng.db.Close() |
There was a problem hiding this comment.
I think we can kill this part of the interface now - the docs don't say it's necessary to do close this connection explicitly https://pkg.go.dev/database/sql#DB.Close
There was a problem hiding this comment.
That's probably fine; in that case we should have logic in place to better handle signals so we can wait for some amount of time before exiting.
Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
adammohammed
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By convention, Infratographer CRDB configs should be a top-level config item. In reconfiguring this, a number of other things shook out including no longer needing (or necessarily even wanting) a separate in-memory storage engine. The dev container supports a database now and we can just create CRDB test servers as needed for testing. This commit refactors the storage package to take a
crdbxconfig directly and defines migrations, tracing, and database seeding as options on the storage engine.