Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Use full ceilometer metric name in metric and cache #103

Merged
merged 6 commits into from
Mar 25, 2021
Merged

Use full ceilometer metric name in metric and cache #103

merged 6 commits into from
Mar 25, 2021

Conversation

pleimer
Copy link
Contributor

@pleimer pleimer commented Mar 19, 2021

Also removes the help string from ceilometer metrics since it did not really provide any extra information.

Resolves: rhbz#1939691

@pleimer pleimer requested a review from leifmadsen March 19, 2021 19:47
@pleimer pleimer changed the title Remove help string from Ceilometer metrics Use full ceilometer metric name in metric and cache Mar 22, 2021
@leifmadsen leifmadsen added the bug Something isn't working label Mar 24, 2021
@leifmadsen
Copy link
Member

Once this merges we'll want to tag another SG release which should result in a downstream import. We'll need to do downstream release work as well to bump the version in the templates for STF 1.2.

Copy link
Contributor

@csibbitt csibbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Did you manage to reproduce the crash and prove that this fixes it?

@pleimer pleimer merged commit 1c35c26 into master Mar 25, 2021
@pleimer pleimer deleted the hotfix branch March 25, 2021 18:14
pleimer added a commit that referenced this pull request Mar 25, 2021
* remove help string from ceilometer metrics

* use whole name for cache index and metric name

* add resource_id back into cache key

* type instance is redundant

* cleanup

* fix ceilo metric tests
@pleimer pleimer mentioned this pull request Mar 25, 2021
pleimer added a commit that referenced this pull request Mar 25, 2021
* remove help string from ceilometer metrics

* use whole name for cache index and metric name

* add resource_id back into cache key

* type instance is redundant

* cleanup

* fix ceilo metric tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants