[change request][Checkbox-group/ChoiceGroupMixin]: including selected disabled options in value

[Charlie-Brownie85]

Hi all!

we're using Lion checkbox-group as the base for the implementation of our own checkbox-list component and we have come to a scenario that might be problematic:

• In the case that one of the inner options needs to be enforced as checked by default, without allowing the user to uncheck it, it will leave this option out of the list of values returned by the parent checkbox-group. (fig.1 and fig.2)

This is caused by explicitly filtering out disabled options on the ChoiceGroupMixin _getCheckedElements() method.

_getCheckedElements() {
  // We want to filter out disabled values by default
  return this.formElements.filter(el => el.checked && !el.disabled);
}

As a native single checkbox can be both disabled and checked at the same time, keeping its checked validity... wouldn't it be beneficial to edit that method to include every checked children option into the checkbox-groups value no matter their disabled state?

[jorenbroekema]

The method _getCheckedElements is protected, so you can override it in your extension.

The reason we filter out disabled, is because typically speaking disabled options are not "interesting" to the app to read out, because we usually just show the disabled option to the user for the sake of being transparent.

I remember this point was a little bit contentious, whether we should filter out disabled options by default or not, back when we discussed this, at least a year ago :P but for the extension, feel free to override :)!

[Charlie-Brownie85]

typically speaking disabled options are not "interesting" to the app to read out, because we usually just show the disabled option to the user for the sake of being transparent

Yeah, we had that same discussion internally and that argument popped up as well 😄

I think we'll extend Lion's checkbox-group and override that method though.

Thanks for the quick response!

Cheers!