-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to popper 2 #1106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f62ed8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tlouisse
force-pushed
the
popper2
branch
2 times, most recently
from
December 19, 2020 16:25
35fee67
to
d99d1de
Compare
jorenbroekema
commented
Dec 30, 2020
packages/helpers/convertPopperConfig/src/convertPopperConfig.js
Outdated
Show resolved
Hide resolved
jorenbroekema
force-pushed
the
popper2
branch
6 times, most recently
from
January 4, 2021 15:55
a1271e8
to
ad59d8e
Compare
jorenbroekema
requested review from
daKmoR,
erikkroes,
gerjanvangeest,
narzac and
ruphin
as code owners
January 4, 2021 15:56
daKmoR
reviewed
Jan 4, 2021
daKmoR
reviewed
Jan 4, 2021
jorenbroekema
force-pushed
the
popper2
branch
2 times, most recently
from
January 5, 2021 12:12
ec021d2
to
05e65da
Compare
tlouisse
reviewed
Jan 5, 2021
tlouisse
reviewed
Jan 5, 2021
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
tlouisse
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the tooltip demo that I changed ('has-arrow' attribute added), looks good, for at least placement top and placement right. So basically POC is done.
TODO: