Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to popper 2 #1106

Merged
merged 1 commit into from
Jan 5, 2021
Merged

feat: upgrade to popper 2 #1106

merged 1 commit into from
Jan 5, 2021

Conversation

jorenbroekema
Copy link
Collaborator

@jorenbroekema jorenbroekema commented Nov 30, 2020

Right now, the tooltip demo that I changed ('has-arrow' attribute added), looks good, for at least placement top and placement right. So basically POC is done.

TODO:

  • Check whether modifiers that have the same name get properly deduped by popper. If so, we can just stack them and don't have to do any merging/deduping ourselves. If not, we may have to create a mergeModifiers helper or something.. now that modifiers is an array (not uniquely-keyed items)
  • I managed to get quite far with fixing types, but there's still some errors. This will be some work to get it all properly..
  • Update Mixin type definition files where needed (ArrowMixin, OverlayMixin)
  • Update lion packages that use/extend popperConfig
  • Make all tests succeed again
  • Update demos (tooltip, overlays etc.)
  • Migration guidelines for our users (link to popper migration guidelines probably is enough, since we mirror their API)
  • Create popper config compatibility layer in our extension library and test it
  • Create changeset release

@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2020

🦋 Changeset detected

Latest commit: 1f62ed8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@lion/overlays Minor
@lion/tooltip Minor
@lion/combobox Patch
@lion/dialog Patch
@lion/input-datepicker Patch
@lion/select-rich Patch
@lion/form-integrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tlouisse tlouisse force-pushed the popper2 branch 2 times, most recently from 35fee67 to d99d1de Compare December 19, 2020 16:25
package.json Outdated Show resolved Hide resolved
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
@jorenbroekema jorenbroekema merged commit 3cf947b into master Jan 5, 2021
@jorenbroekema jorenbroekema deleted the popper2 branch January 5, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants