Fixed grammar

[passchn]

IBAN is feminin in German: https://www.duden.de/rechtschreibung/IBAN

What I did

1. Changed spelling/grammar of the german error message for an invalid IBAN.

[changeset-bot]

🦋 Changeset detected

Latest commit: 47aa452

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lion/ui	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[CLAassistant]

All committers have signed the CLA.

[gerjanvangeest]

thanks for the fix 💪

Can you add a changeset (npm run changeset) so it will end up in our changelog?

[tlouisse]

thanks for the fix 💪

Can you add a changeset (npm run changeset) so it will end up in our changelog?

Good that you point this out indeed. However, we have to deal with some edge cases.

Maybe it can be solved with the same approach as in the Dutch language? https://github.com/ing-bank/lion/blob/master/packages/ui/components/input-iban/translations/nl.js#L3
So that would be ein(e) gültige(s) in German?

Why that's needed

Since {fieldName} (corresponding to the .fieldName prop of the FormControl) can be:

• the .fieldName (when provided by the user)
• the .label (when no .fieldName provided)

Since we don't know whether the noun (IBAN or anything else) is going to be feminine or not, we don't know what our adjective (gültiges/gültige) + article ("ein" vs "eine") should be.

💡 Possible ways of making this better...

Although ein(e) gültige(s) would provide a valid outcome in all scenarios, it's not the nicest thing to read as an end user.
We might be able to improve UX by looking into a way to also configure the adjective and article of a Validator message for a certain article+adjective+fieldName combo

[passchn]

I can't really think of a probable scenario where the noun is neutrum in case of the IBAN field's label.

Useful labels are "IBAN", "Nummer", maybe "Kontonummer" which are all feminin. You really have to be creative to come up with a neutrum word.

Anyway, it would be great to be able to configure the messages, I think! Maybe they could also be passed as attributes to the WebComponent.

[tlouisse]

I can't really think of a probable scenario where the noun is neutrum in case of the IBAN field's label.

Useful labels are "IBAN", "Nummer", maybe "Kontonummer" which are all feminin. You really have to be creative to come up with a neutrum word.

Anyway, it would be great to be able to configure the messages, I think! Maybe they could also be passed as attributes to the WebComponent.

It's definitely a more sensible default than wat it was before, but in case the label would be "Iban Text", the fieldName would be masculine for instance...

Having a closer look at it: in German it can be gültiger|gültige| gültiges etc.: https://www.verbformen.com/declension/adjectives/gu3ltig.htm

So a one-size-fits-all solution like we have in Dutch is not possible for the German language.

The best solution for now will then be:

• use the translation you proposed
• give lion-input-iban a default fieldName of 'iban' (then it takes precedence over the label text and it will always be correct, unless the developer overrides .fieldName)

In case the user overrides .fieldName, it will always be possible to override the complete message.

[tlouisse]

Thanks @passchn!
Added this issue as a follow-up for further finetuning: #1940