feat: add loading indicator #857
Conversation
🦋 Changeset is good to goLatest commit: ea66e40 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
| @@ -0,0 +1,3 @@ | |||
| export default { | |||
| loading: 'Loading', | |||
There was a problem hiding this comment.
The accessibility readers will see this component as "Loading", which is probably correct in nearly all cases, but there may be places where a progress indicator is used that does not indicate "Loading" but something else. Do we want to make it possible to override this?
There was a problem hiding this comment.
Makes sense. We could consider calling a method _setLabel() inside onLocaleUpdated, so Sub classers can override this
|
TODO: Add a changeset to this pull request |
|
I added a changeset to release version 0.1.0 of this. I think all comments have been addressed. The tests are failing because test coverage is not high enough, although I don't think it's caused by this package. The tests for this are passing. Feel free to merge if it passes review. |
Co-authored-by: Thomas Allmer <thomas.allmer@ing.com>
ruphin
force-pushed
the
loading_indicator
branch
from
7afc5ca
to
ea66e40
Compare
This adds a loading indicator package. There are some things I'm not super satisfied with, so please review carefully and check my notes.