Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hist_juxtaposition #245

Merged
merged 4 commits into from
Sep 1, 2022
Merged

feat: hist_juxtaposition #245

merged 4 commits into from
Sep 1, 2022

Conversation

pradyot-09
Copy link
Collaborator

For now, the last_n is by default set to 2. Therefore, only two dates would appear in the dropdown. For the airline dataset if the last_n is set to max, popmon runs into the issue (for DEPARTURE feature) raised by Tomek #244.

Screenshot 2022-08-15 at 19 39 24

closes #230

@pradyot-09 pradyot-09 added the enhancement New feature or request label Aug 15, 2022
Copy link
Collaborator

@sbrugman sbrugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far. The reports notebook needs to be updated so that the tests pass. After, it's easier to review the resulting report.

popmon/visualization/templates/assets/js/custom-script.js Outdated Show resolved Hide resolved
@sbrugman
Copy link
Collaborator

sbrugman commented Aug 18, 2022

Now that the issue in histogrammar should be resolved, we can test if that results in a passing ci/cd here.

@pradyot-09 Until there is a new histogrammar release, you could add the git branch to requirements.txt for development purposes. Adding a line such as this should work:

histogrammar @ https://github.com/histogrammar/histogrammar-python.git

@sbrugman
Copy link
Collaborator

@pradyot-09 popmon_tutorial_reports.ipynb needs to be updated for the tests to pass

Base automatically changed from develop to master August 19, 2022 13:13
@sbrugman sbrugman changed the base branch from master to develop August 19, 2022 15:26
@sbrugman
Copy link
Collaborator

The current implementation is a great step forward, as it allows users to view individual histograms, which wasn't possible before:

image

The implementation might be better using two plotly dropdowns in the same figure. This removes the redundant information that is now present in the plots: the reference is available both left and right, and histogram_prev1 is the same as histogram once selected.

@sbrugman sbrugman force-pushed the feat/hist_juxtaposition branch 2 times, most recently from 1174c6d to 3249fac Compare August 19, 2022 16:02
@pradyot-09
Copy link
Collaborator Author

@sbrugman Just to clarify: A single plot with a dropdown to change the dates? asking because we discussed one of the main reason to have the plots side by side was to compare them.

@sbrugman
Copy link
Collaborator

@sbrugman Just to clarify: A single plot with a dropdown to change the dates? asking because we discussed one of the main reason to have the plots side by side was to compare them.

Side-by-side or overlay should be both fine. The confusion in the current approach is the redundant information (histogram_prev1 may be the same as histogram in the other). You could consider adding the reference to the drop-down, and showing one histogram per drop-down.

@pradyot-09
Copy link
Collaborator Author

pradyot-09 commented Aug 25, 2022

@sbrugman Have pushed the histogram plots with updatemenus. The code looks neater now. For static references the "histogram_ref" plots are repetitive. I think it would be clever to have the "histogram_ref" only once for static references. However, I think that we would need to pass the Settings object rather than the Report object to report_generation(). Not sure about the best way to get reference_type in histogram_section.
Screenshot 2022-08-25 at 18 12 54

@pradyot-09
Copy link
Collaborator Author

@sbrugman pushed the new histogram inspector with overlays. For now, I have kept double dropdowns for static reference too because I thought it was just very easy to disable overlays if needed. Let me know what you think.
Screenshot 2022-08-31 at 09 19 00

@sbrugman sbrugman merged commit 64a4952 into develop Sep 1, 2022
@sbrugman sbrugman deleted the feat/hist_juxtaposition branch September 1, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants