Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat tests to improve readability #40

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Reformat tests to improve readability #40

merged 4 commits into from
Oct 14, 2022

Conversation

craig410
Copy link
Member

No description provided.

@craig410
Copy link
Member Author

@acoulton shall we release this as v4.8.6.1 to keep the release bringing in PHP 8.1 support clean?

acoulton
acoulton reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good plan to release this separately.

Is it worth adding that magic github file to skip past the reformat commit for blame?

tests/kohana/ExceptionTest.php Outdated Show resolved Hide resolved
@craig410 craig410 merged commit 2691672 into 4.x Oct 14, 2022
@craig410 craig410 deleted the reformat-test-code branch October 14, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoulton acoulton acoulton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craig410 @acoulton