Experimental test on PHP 8.2 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig410
force-pushed
the
support-php81
branch
2 times, most recently
from
7f368fd
to
7434d0e
Compare
craig410
force-pushed
the
experimental-test-php82
branch
from
45de8e6
to
0d22897
Compare
acoulton
reviewed
Oct 14, 2022
If the only place Request::_routes is ever set is from here - and it's never read... this must be left behind from previous refactorings
craig410
force-pushed
the
experimental-test-php82
branch
from
fe86b8d
to
d9b477d
Compare
|
@acoulton happy I merge this into the 8.1 branch and release both together? |
acoulton
approved these changes
Oct 14, 2022
| @@ -16,7 +16,7 @@ | |||
| class Kohana_HTTPTest extends Unittest_TestCase | |||
| { | |||
|
|
|||
| protected $_inital_request; | |||
| protected ?Request $_initial_request; | |||
There was a problem hiding this comment.
Good example of how the dynamic property depreciation will help overall!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.