Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: div by 0 when number of Elements is 1 #230

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

jeremyfelder
Copy link
Collaborator

Describe the changes

This PR fixes a div by 0 edge case in NTT when the number of elements is 1

ImmanuelSegol
ImmanuelSegol previously approved these changes Sep 28, 2023
Copy link
Contributor

@ImmanuelSegol ImmanuelSegol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to write a test for this ?

vhnatyk
vhnatyk previously approved these changes Sep 28, 2023
@jeremyfelder jeremyfelder merged commit 97f0079 into main Sep 28, 2023
10 of 11 checks passed
@jeremyfelder jeremyfelder deleted the fix/tiny-circuit-edge-case branch September 28, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants