Complete overhaul of python-twitch #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingwinlu
force-pushed
the
split_init
branch
17 times, most recently
from
506e9a3
to
1b11fa4
Compare
* add flake8 config * add flake8 env section * add flake8 to travis build's
* module v2 and v3 api's as modules * expand scraper to be able to handle headers and parameters * implement v3 * channels * streams * users * videos * games * search * stub v2 module * implement usher * live * vod * hidden_api for tokens * hidden_api for videos * add ResourceUnavailableException All Queries now throw an ResourceUnavailableException when a HttpException is triggered by the underlaying download function. * replace old M3U parser with a regex parser
Custom Exceptions were still a leftover from before the library breakout. Since Exception handling is application territory they have been removed. A custom ResourceUnavailable Exception got introduced during the rework that is called when a Query execution fails with a str() representation of that Query.
Most Keys in the keys module are not needed anymore as we don't care about value extraction anymore. The library should stay a enabler, the keys are for self benefit only. With the introduction of DAO classes most of those keys might need to be reintroduced.
ingwinlu
force-pushed
the
split_init
branch
2 times, most recently
from
dd64c67
to
23892d7
Compare
ingwinlu
added a commit
that referenced
this pull request
Oct 1, 2015
Complete overhaul of python-twitch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split up moduleflake8 compatibilitymodel closer to twitch api documentation ( more rest like )redo url module, needs to be able to easily build all rest api callsv3 api, did not implement auth or put/delete stuff yetv2 api, delay, not needed asapusher apiredo loggingall internal data should be unicode, postponedprovide updated and old api via deprecation layer, dropped due to time constrains, old versions are still available as tagsredo m3u8 parsing via regexcleanup unused stuffcreate issues for the following things:
twitch.api.teams()would list the first 25 teams, viatwitch.api.teams.next()andtwitch.api.teams.prev()jump to next or prev listing, since the old api partly substituted resultsets, will need to maybe add a transform functionality as well