New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace two-arg open with three-arg open #64

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Aug 10, 2017

The three-argument version of the open function is considered better
practice than the older two-argument open.

This pull request is intended to be helpful. If you have any questions or comments, please don't hesitate to contact me and I'll update the PR as necessary and resubmit.

Replace two-arg open with three-arg open
The three-argument version of the `open` function is considered better
practice than the older two-argument `open`.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage increased (+0.01%) to 87.302% when pulling 5727768 on paultcochrane:pr/use-three-arg-open into d509bcc on ingydotnet:master.

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.01%) to 87.302% when pulling 5727768 on paultcochrane:pr/use-three-arg-open into d509bcc on ingydotnet:master.

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Nov 8, 2017

Collaborator

Thanks, applied!

Collaborator

perlpunk commented Nov 8, 2017

Thanks, applied!

@perlpunk perlpunk closed this Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment