Skip to content

Commit

Permalink
Make MyRocks DD commits always durable (facebook#1403)
Browse files Browse the repository at this point in the history 
Summary:
Regular commit durability is governed by the binlog group commit algorithm and system variables. Make any commits (and prepares in 2PC) involving DD tables always durable unconditionally, just like InnoDB does. It is implemented through a new flag `Rdb_transaction::m_dd_transaction`, which is set in `ha_rocksdb::external_lock` and checked in `rocksdb_prepare`. To avoid confusion, rename the existing `m_ddl_transaction` flag to `m_bulk_index_transaction`.

Pull Request resolved: facebook#1403

Differential Revision: D51872251

fbshipit-source-id: 64290c8
  • Loading branch information
@laurynas-biveinis @inikep
laurynas-biveinis authored and inikep committed May 17, 2024
1 parent 68099eb commit 07598db
Show file tree
Hide file tree
Showing 4 changed files with 626 additions and 13 deletions.
Loading

0 comments on commit 07598db

Please sign in to comment.