htmlparser2 adapter uses no html-encoding in text nodes

[Sebmaster]

Compare this test script:

var parse5 = require('parse5');

var rawHtml = '<b>World</b>';

var parser = new parse5.Parser(parse5.TreeAdapters.htmlparser2);
var dom = parser.parseFragment(rawHtml);

console.log(dom.children[0].data);

var htmlparser2 = require('htmlparser2');
var handler = new htmlparser2.DefaultHandler();
var parserInstance = new htmlparser2.Parser(handler, {
  xmlMode: false,
  lowerCaseTags: true,
  lowerCaseAttributeNames: true
});

parserInstance.includeLocation = false;
parserInstance.parseComplete(rawHtml);

console.log(handler.dom[0].data);

which produces this ouput:

<b>World</b>
<b>World</b>

Seems like text nodes already contain decoded data in parse5 and it's used as-is in the tree adapter?

[fb55]

jsdom's entity decoding isn't entirely spec compliant & should be replaced with the parser-provided alternatives. htmlparser2 has a decodeEntities option, which results in the same behavior.

[domenic]

The more of that kind of thing we can move into the parser, the better. I am not exactly sure how to do that, but we'll look into it...

[Sebmaster]

While I do agree that we should move that kind of thing into the parser as far as possible, this problem doesn't stem from jsdom.

I'd expect the htmlparser2 tree-adapter to produce the same output format as htmlparser2 itself, however apparently this is not the case.

[Sebmaster]

Oh well, thanks @fb55, had more time to look into it just now. Seems like we can drop our custom HTMLDecode function and use htmlparser2/parse5 for that. Thanks!