Load generated content #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The world encompasses more than just generating content. Anything routed to the `world` module is now a WorldCommand.
Matching past behaviour with npc, split LocationSummaryView and LocationDetailsView into a separate view module.
Since the views are found in the npc and location mod namespaces, there's no need for repetition in the struct name.
Thing also now has its own file. This will support adding more code for views.
Remove leading and trailing newlines from generator output for consistency of rendering. Necessary padding has instead been moved into the rendering layer (cli and web). Also updated whitespace handling of other views to ensure that output should never have leading or trailing newlines.
Proper nouns are now recognized as one or more capitalized words in sequence. Adjacent capitalized words are greedily consumed.
Now anyThing can be rendered as summary/details without prior knowledge of what sort of Thing (Npc, Location, etc.).
It is now possible to load a previously-generated entity by typing its name. The parsing is super kludgy: any command containing a proper noun is currently interpreted to be a request to load data. But a journey of a thousand miles blah blah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now not only do we save content as it is generated on the fly, it is also possible to load that content after the fact by invoking the name of the generated entity.
Resolves #30