Code cleanup for local storage #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it gets fussy about needless borrowing.
* mv web/build.sh -> build.sh (this will break CF build) * add dev-server.sh * add test.sh to run all tests
The World struct will be wanted one day in the post-MVP era, but it's just cluttering things up for now.
Bike shedding a bit here, but added a macro to cover the various uuid wrappers (eg. npc::Uuid, location::Uuid).
Bootstrapping is no longer necessary as of Webpack 5.
npc and location both had their own command functions. These have been split off, like the higher-level commands.
Not sure yet how the uuid stuff is going to land as it's still a work in progress, but the Rc thing seems dead on arrival.
The building module is going to get very cluttered indeed, especially as we start making generators more robust.
The signal to noise ratio sucked. Better to split into more files than to try to cram multiple tests into a single file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A grab bag of cleanups and upgrades in preparation for local storage work.