Preliminary arc support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only non-rotated arcs for now. cx and cy seem accurate, but the arc and sweep appear to have a pretty large (rounding?) errors - do you see where these might be coming from?
|
It seems pretty close to me.
|
Not yet completely right nor do I understand exactly what this means yet, but this gets rid of our 'rounding error'. Still some work to do since there's some sign errors left to be worked out
This covers drawing non-rotated arcs, which I suspect are the common ones. I noticed relatively-positioned arcs are not handled correctly, but that might be a separate issue altogether.
Closed
|
@frmdstryr in that picture you had an arc that started at angle 0 and spanned the full 360 degrees - that indeed worked, but my algorithm was incorrect for most other angles since I mixed up 'phi' and 'theta'. I think it should be fine now though! |
|
(please squash when merging) |
Avoid drawing a straight line from start to end or interfering with the 'current' position.
frmdstryr
approved these changes
Mar 30, 2018
frmdstryr
reviewed
Sep 21, 2018
| y1 = self.currentPosition().y() | ||
| (rx, ry, x_axis_rotation, large_arc_flag, sweep_flag, x2, y2) = params | ||
|
|
||
| self.arc(x1, y1, rx, ry, x_axis_rotation, large_arc_flag, sweep_flag, x2, y2) |
There was a problem hiding this comment.
Looking at this again... does x_axis_rotation need to be converted to radians here?
https://www.w3.org/TR/SVG/paths.html#PathDataEllipticalArcCommands "and an x-axis-rotation, which indicates how the ellipse as a whole is rotated, in degrees, relative to the current coordinate system".
All of python's trig functions take radians https://docs.python.org/2/library/math.html#trigonometric-functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only non-rotated arcs for now.
cx and cy seem accurate, but the arc and sweep appear to have a pretty
large (rounding?) errors - do you see where these might be coming from?