-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial step 2 - Uplift to latest ink! and Openbrush #14
base: tutorial/mint-step2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#[overrider(PSP34Mintable)] | ||
#[openbrush::modifiers(only_owner)] | ||
fn mint(&mut self, account: AccountId, id: Id) -> Result<(), PSP34Error> { | ||
psp34::InternalImpl::_mint_to(self, account, id) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is not needed since we added mint() in the contract implementation.
However if OB can now support payable in the overriden function then mint
is not needed in the contract implementation
instance._init_with_owner(instance.env().caller()); | ||
let collection_id = instance.collection_id(); | ||
instance._set_attribute( | ||
let mut _instance = Self::default(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not use _
since the variable is used
@@ -29,4 +22,4 @@ std = [ | |||
|
|||
"openbrush/std", | |||
] | |||
ink-as-dependency = [] | |||
ink-as-dependency = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new line
No description provided.