Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift to ink v4 #117

Merged
merged 3 commits into from
Feb 26, 2023
Merged

Uplift to ink v4 #117

merged 3 commits into from
Feb 26, 2023

Conversation

HyunggyuJang
Copy link
Contributor

@HyunggyuJang HyunggyuJang commented Feb 25, 2023 •
edited
Loading

Now cargo contract released the stable version of v2.0.1, and it only supports from ink v4. Closes #105. Also partly handles #109 (the ink version part).

@keisukefunatsu keisukefunatsu mentioned this pull request Feb 25, 2023
Closed
shunsukew
shunsukew approved these changes Feb 26, 2023
View reviewed changes
Copy link
Contributor

@shunsukew shunsukew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,
Could you also update swanky-node download url to the latest one?
https://github.com/AstarNetwork/swanky-node/releases/tag/v1.1.0

v1.1.0 uses substrate polkadot-v0.9.37 branch, which is officially mentioned in the ink! 4.0.0's release note. https://github.com/paritytech/ink/releases/tag/v4.0.0

@HyunggyuJang
Copy link
Contributor Author

Thank you, Could you also update swanky-node download url to the latest one? https://github.com/AstarNetwork/swanky-node/releases/tag/v1.1.0

v1.1.0 uses substrate polkadot-v0.9.37 branch, which is officially mentioned in the ink! 4.0.0's release note. https://github.com/paritytech/ink/releases/tag/v4.0.0

Done :)

@shunsukew shunsukew requested review from codespool and removed request for codespool February 26, 2023 12:00
@shunsukew
Copy link
Contributor

Seems commits need to be signed to be merged

@HyunggyuJang
Copy link
Contributor Author

Seems commits need to be signed to be merged

Done! :)

@shunsukew
Copy link
Contributor

Seems commits need to be signed to be merged

Done! :)

Thank you!

@shunsukew shunsukew merged commit 7561106 into inkdevhub:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunsukew shunsukew shunsukew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for cargo-contract 2.x
3 participants
@HyunggyuJang @shunsukew @keisukefunatsu