Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added install swanky node command #131

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Conversation

shunsukew
Copy link
Contributor

@shunsukew shunsukew commented Mar 28, 2023

For those who initialize projects without local swanky node but later would like to use.

packages/cli/src/commands/node/install.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/node/install.ts Outdated Show resolved Hide resolved
@kziemianek
Copy link
Contributor

Looks like great feature.

In our case we ended up pushing swanky-node to git repository (not included in .gitignore). With recent release of swanky-node 1.4.0 which size is greater than 100 mb we cannot push it to GitHub anymore due to limits.

Generally I was sceptic about pushing binary to GitHub, but with this feature we will probably remove it because we will be able to download node with this command after cloning repository.

Additionally to this feature I would love to see some kind of swanky-node version locking mechanism (like package.lock.json) to share the same node across devs ends.

@shunsukew
Copy link
Contributor Author

shunsukew commented Mar 29, 2023

Thank you so much for the feedback!

Additionally to this feature I would love to see some kind of swanky-node version locking mechanism (like package.lock.json) to share the same node across devs ends.

That would be a great feature, I assume that can be part of swanky.config.json. If version is already defined, install that version of node instead of the latest one.
It's also feasible to specify a version with the command arg. swanky node install asks users if they would like to overwrite node binary, they can chose whichever version they want anytime.

eval prio
arg -> config file -> latest version by default

@shunsukew shunsukew requested a review from codespool April 7, 2023 03:53
Copy link
Collaborator

@codespool codespool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shunsukew shunsukew merged commit 35e5328 into master Apr 13, 2023
@shunsukew shunsukew deleted the feature/install-node-command branch April 13, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants