Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves panic when receiving message > 1024 #10

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Resolves panic when receiving message > 1024 #10

merged 2 commits into from
Sep 22, 2017

Conversation

bndw
Copy link
Contributor

@bndw bndw commented Aug 11, 2016

Resolves #4 by increasing the reader's buffer size when the message is larger than the initial allocation.

@inkel
Copy link
Owner

inkel commented Aug 25, 2016

Hi, thanks for taking an interest on this! This was a small proof of concept project to learn some Go programming, so I'm surprised someone took the time to actually check the code 😸

I mostly agree with the changes, however I don't understand the need to change the import paths: doing it so no longer references this project but your fork. I'm all 👍 on you forking the project, don't get me wrong, but then there would be no need to send a pull request if it's going to change the references 😉

@bndw
Copy link
Contributor Author

bndw commented Jan 5, 2017

Hi @inkel,

After submitting the PR and not hearing anything for a few days, I needed to move forward with the patch I applied, so I began using my fork. In order for that fork to actually work, I had to change the import paths.

I'm no longer using my fork, so I'd be happy to undo the import changes and resubmit a patch it you like :)

@inkel
Copy link
Owner

inkel commented Jan 16, 2017

Yes, please do! Thank you 😸

@bndw
Copy link
Contributor Author

bndw commented Jan 17, 2017

There you go!

@inkel inkel merged commit 5ea287c into inkel:master Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants