Flush the writer when a full object is written #717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a large amount of JSON to a StreamWriter it's possible for the JSON to get truncated because the writer is never flushed before it's closed. This PR changes SimpleJson to flush whenever the end of an object is written and the state stack becomes empty.
To reproduce the truncation (before this change) you can do:
On my box my particular ink script results in a truncated JSON file a bit longer than 5,000 chars. After the fix it results in a complete JSON file over 6,000 chars.