Force refresh of List origins when accessed via VariablesState to fix bug where some Lists loaded from file don't get initialized. #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug where some Lists loaded from file don't get initialized.
…h could crash with a null pointer.
shinyu6
added a commit
to shinyu6/ink
that referenced
this pull request
May 7, 2023
|
As described in issue, this is an issue but I'd rather not accept this specific fix. |
|
Yeah, I agree. I figured you'd be able to fix it in a more comprehensive way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my (hacky?) fix for the bug I describe here: #763
This PR adds a check when an
InkListis accessed viaVariablesStateto see if itsoriginsis null. If it is, then it tries to populate them at that point. The rest of the changes are some code refactoring to keep the origin-setting code in one place.This has fixed my specific problem, but it's almost certainly not a comprehensive fix. Hopefully it's a useful start though.
The real fix should probably make sure all
InkListoriginsare populated after aLoadJson(). I don't understand the entire runtime enough to do that.