Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$(selector) should actually return all elements found by selector, else length=0 if no elements found #5

Closed
wants to merge 2 commits into from

Conversation

ashbrener
Copy link

(have also updated author of my previous commit, was using an old github account)

@loganfsmyth
Copy link
Contributor

I already merged the other PR so this conflicts. Can you elaborate on your use-case here? We never worried about the multi-element case because we're trying to only cover the cases used by Backbone, not be a general-purpose library. In the case of Backbone, you wouldn't have a this.$el with multiple elements.

@ashbrener
Copy link
Author

Understood, our intention is to leverage backbone.native for some of the simpler expected jQuery behavior (given that the functions have already been made available to the document by backbone.native).

The use case is a small single-file .js api that doesn't depend on the full jQuery lib, but employs a handful of the more commonly used functions to keep html rendering / manipulation code lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants