Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also seems like lint rules don't play good with these plugins: #1578

Closed
samuelstroschein opened this issue Nov 2, 2023 · 7 comments
Closed
Labels
scope: inlang/plugins Related to plugins (not necessarily inlang source code). type: bug Something isn't working

Comments

@samuelstroschein
Copy link
Member

          Also seems like lint rules don't play good with these plugins:
> inlang lint

                                                                                                       10:51:51 PM
🚨 Lint Report                                                                                         10:51:51 PM
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”  10:51:51 PM
β”‚ Level      β”‚ Lint Rule                         β”‚ Message                                          β”‚
β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€
β”‚ Warning    β”‚ messageLintRule.inlang.identical… β”‚ Identical content found in language 'ru' with    β”‚
β”‚            β”‚                                   β”‚ message ID 'global_available_language_en_tag'.   β”‚
β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€
β”‚ Warning    β”‚ messageLintRule.inlang.identical… β”‚ Identical content found in language 'zh' with    β”‚
β”‚            β”‚                                   β”‚ message ID 'global_available_language_en_tag'.   β”‚
β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€

Using the same setup as above. Do you want me to open separate issue for this?

Originally posted by @ZerdoX-x in #1577 (comment)

@maige-app maige-app bot added type: bug Something isn't working scope: inlang/plugins Related to plugins (not necessarily inlang source code). labels Nov 2, 2023
@samuelstroschein
Copy link
Member Author

@inlang/plugins can someone look into this?

@ZerdoX-x
Copy link
Contributor

ZerdoX-x commented Nov 3, 2023

@samuelstroschein could you please close the issue?

I misread the warning message from lint rule and though that it's about id duplication across different files.

Shame on me πŸ™Š

@ZerdoX-x
Copy link
Contributor

ZerdoX-x commented Nov 3, 2023

Btw, just wondering, If I could add support for nushell table-like output format (for nu shells, for others regular ascii tables), would you be interested in merging feature like this into CLI?
image

@NilsJacobsen
Copy link
Collaborator

tagging @felixhaeberle, cause he mainly maintains the cli.

@felixhaeberle
Copy link
Contributor

@ZerdoX-x Feel free to change the table, I was never satisfied with the current one. It's very straightforward to change it. Will review the PR πŸ‘

@ZerdoX-x
Copy link
Contributor

ZerdoX-x commented Nov 3, 2023

@ZerdoX-x Feel free to change the table, I was never satisfied with the current one. It's very straightforward to change it. Will review the PR πŸ‘

Got you. Could you also please close this issue? It is not relevant and all works as expected with linting rules, i just misread the message.

@felixhaeberle felixhaeberle closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
@samuelstroschein
Copy link
Member Author

@felixhaeberle can we show the displayName of a lint rule instead of the id in the table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: inlang/plugins Related to plugins (not necessarily inlang source code). type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants