-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hetzner provider. #72
Conversation
Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Hi @Johannestegner thanks for the PR - it will be nice to have Hetzner available as an option for inlets users. @zechenbit would you be able to review this patch please? Alex |
@Johannestegner could you test with inlets PRO? Here's a license you can use:
The way to switch is to use |
Please also update this file -> https://github.com/inlets/inletsctl/blob/master/pkg/provision/README.md |
Will do! Just finishing off dinner real quick :) |
…ete instead of throwing an exception. Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
…rs/README.md Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
@alexellis took me a bit to figure out that I was using the wrong IP address of my local machine.... but when that was done, I could publish multiple services via the end node, so seems to work fine :) |
@Johannestegner please take a look at the feedback by @zechenbit and if there is an Ubuntu 16.04 image, let's use that for consistency please? |
@alexellis @zechenbit sending kids off with their grandma, then I'll take care of this :) |
Thank you, it would be great to get this released before Friday end of play, so that I can include it in the Insiders Update for this week. |
Removed default settings from the provider file, as they are already set in the create.go file. Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Added some comments to why a label is used on provisioned vps. Added comments about where to find information about the Plan, OS and Regions for Hetzner. Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Signed-off-by: Johannes Tegnér <johannes@jitesoft.com>
Could you update "How Has This Been Tested?" with your results from re-testing with the new commits? 👍 thank you for the quick turn-around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@alexellis Will do! Give me a couple of minutes :) |
Worked just as well, I added a small comment, if you want me to show some logs or similar I will gladly add them too :) |
Thank you guys! Was fun to write some Go for a change! :D |
Description
This pull request contains code which allows for provisioning of the cheapest server type at Hetzner cloud to be used as an inlet end node.
I made the default region hel1 (Helsinki, Finland) and the server type is the cx11 (€2.49/month) with Ubuntu 20.04.
This should close #67 if accepted.
How Has This Been Tested?
I tested the provider manually multiple times on Windows 10 Pro and on Ubuntu 18.04 (via WSL2).
The following steps was taken:
Edit after testing with latest commits:
Used the same procedure as above, with all available regions, with same successful result.
How are existing users impacted? What migration steps/scripts do we need?
No changes, only a new provider added.
Checklist:
I have:
git commit -s