Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): ensure Python SDK deeply nested menu items stay visible when active #864

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

charlypoly
Copy link
Contributor

Before

The Python SDK section closes when navigating to the nested Steps items

image

After

The Python SDK section remains open when navigating to the nested Steps items

image

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:28am

@charlypoly charlypoly changed the title fix(docs): ensure Python SDK deeply nested menu item stay visible when active fix(docs): ensure Python SDK deeply nested menu items stay visible when active Jul 19, 2024
@charlypoly charlypoly self-assigned this Jul 19, 2024
@charlypoly charlypoly added bug Something isn't working documentation Improvements or additions to documentation labels Jul 19, 2024
Copy link
Contributor

@sylwiavargas sylwiavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I did a WIP fix some time ago (between conferences so it stayed WIP forever). That had some tradeoffs and it didn't occur to me we could approach it this way 😂

@sylwiavargas sylwiavargas requested a review from amh4r July 19, 2024 09:48
@sylwiavargas sylwiavargas merged commit fc1fe71 into main Jul 19, 2024
5 checks passed
@sylwiavargas sylwiavargas deleted the fix/docs-python-sdk-reference-nested-menu-items branch July 19, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants