Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when value greater than 999, not count up expected #9

Closed
rikan opened this issue May 17, 2018 · 2 comments
Closed

when value greater than 999, not count up expected #9

rikan opened this issue May 17, 2018 · 2 comments

Comments

@rikan
Copy link

rikan commented May 17, 2018

[x] Bug
[ ] Build issue
[ ] Feature request

Version info

Angular: 5
Angular CLI: 
countup.js-angular2: 

Description

Hi @inorganik ,

when start value and end value both greater than 999, the component become count down, not count up expected.

for example
start value is 100000
end value is 100099

I think the issue caused by this code.

    if (end > 999) {
      // make easing smoother for large numbers
      countUp = new CountUp(this.el.nativeElement, sta, end - 100, dec, dur / 2, this.options);
    }

Please have a look.
Thanks.

@inorganik
Copy link
Owner

Ah, yes that is a bug. I'll make a fix soon. Thanks.

@inorganik
Copy link
Owner

Fixed in v6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants