Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qc login #80

Merged
merged 2 commits into from
Jul 18, 2022
Merged

qc login #80

merged 2 commits into from
Jul 18, 2022

Conversation

velrest
Copy link
Contributor

@velrest velrest commented Jul 4, 2022

  • fix(docker): run server with poetry so deps are found
  • feat(hous_stat_creds): creds are identified by user and x-camac-group

@velrest velrest requested review from winged and luytena July 4, 2022 17:24
winged
winged requested changes Jul 5, 2022
View reviewed changes
Copy link

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming functions: use pep8 naming (snake case), otherwise LGTM

ebau_gwr/token_proxy/migrations/0003_housingstatcreds_group.py Outdated Show resolved Hide resolved
@velrest velrest force-pushed the qc-login branch 2 times, most recently from 1484450 to 192c7d9 Compare July 7, 2022 08:26
@velrest
feat(hous_stat_creds): creds are identified by user and x-camac-group
7894081 
This allows users to have multiple stored credentials and allows them
to easily switch between groups and have the correct gwr credentials.
@velrest velrest merged commit ada330c into inosca:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

@luytena luytena Awaiting requested review from luytena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@velrest @winged