feat(global): add quarterly closure #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velrest
force-pushed
the
qc-quarterly-closure
branch
3 times, most recently
from
3dcd42d
to
ba9b42d
Compare
Pending RequestThis happens if |
BFS Action neededThis is mostly the case after a municipality calls |
Municipality action required
|
Errors need fixing
|
Finalized
|
velrest
force-pushed
the
qc-quarterly-closure
branch
3 times, most recently
from
dadb348
to
ceee6dc
Compare
Merged
|
Regarding the UI: |
velrest
force-pushed
the
qc-quarterly-closure
branch
from
ceee6dc
to
69341d5
Compare
luytena
reviewed
Jul 20, 2022
luytena
reviewed
Jul 20, 2022
| @service intl; | ||
|
|
||
| get disabledButton() { | ||
| return ![620, 630, 650, 651, 663, 665].includes( |
There was a problem hiding this comment.
Maybe replace with constants
luytena
reviewed
Jul 20, 2022
| import { helper } from "@ember/component/helper"; | ||
| import { DateTime } from "luxon"; | ||
|
|
||
| const currentQuarter = function isUnset([format = "q/yyyy"]) { |
There was a problem hiding this comment.
Should display quarter being worked on, not by date
luytena
reviewed
Jul 20, 2022
luytena
reviewed
Jul 20, 2022
velrest
force-pushed
the
qc-quarterly-closure
branch
from
1a631ce
to
8b38d95
Compare
velrest
force-pushed
the
qc-quarterly-closure
branch
from
8b38d95
to
4238acc
Compare
luytena
approved these changes
Jul 20, 2022
This was referenced Jul 20, 2022
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.