Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Missing Source Event bug #67

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Fixed Missing Source Event bug #67

merged 3 commits into from
Oct 8, 2023

Conversation

HannesHil
Copy link
Contributor

@HannesHil HannesHil commented Sep 3, 2023 •
edited by MichaelEischer
Loading

Fixes #68

@HannesHil HannesHil mentioned this pull request Sep 3, 2023
Closed
@MichaelEischer MichaelEischer mentioned this pull request Sep 26, 2023
Closed
@MichaelEischer
Copy link
Collaborator

I've replaced the placeholder commit with a proper implementation.

alxndr13
alxndr13 reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@alxndr13 alxndr13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i'll add a .mockery.yaml file as that is the new preferred way to go now. (is in: #81)

imo, we should rename the "GetSourceID" func in the Sink and Source as it does not match the Sink Adapter. We may strive for something more generic, like "GetAdapterID" or something like this.

what do you think? @MichaelEischer

internal/sync/controller_test.go Outdated Show resolved Hide resolved
@alxndr13 alxndr13 mentioned this pull request Oct 4, 2023
Merged
@MichaelEischer
Copy link
Collaborator

We may strive for something more generic, like "GetAdapterID" or something like this.

I'd somewhat prefer GetCalendarID. That works for both source and sink, but is clear on what the ID identifies.

@MichaelEischer
feat: do not resurrect event when syncing in both directions
9079fe5
@MichaelEischer
refactor: rename Source/Sink.GetSourceID to GetCalendarID
320f03a 
The method returns an ID that can be used to identify the underlying
calendar. Thus use a more neutral name than GetSourceID.
@alxndr13
Copy link
Contributor

alxndr13 commented Oct 7, 2023

We may strive for something more generic, like "GetAdapterID" or something like this.

I'd somewhat prefer GetCalendarID. That works for both source and sink, but is clear on what the ID identifies.

perfect. will create something once i'm home.

@MichaelEischer
Copy link
Collaborator

perfect. will create something once i'm home.

@alxndr13 I've already added a commit to apply that rename.

@alxndr13
Copy link
Contributor

alxndr13 commented Oct 8, 2023

perfect. will create something once i'm home.

@alxndr13 I've already added a commit to apply that rename.

whoops, did not saw that on the Github iOS App. lgtm

@MichaelEischer MichaelEischer merged commit 716ff6f into inovex:main Oct 8, 2023
@MichaelEischer MichaelEischer mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxndr13 alxndr13 alxndr13 approved these changes

@MichaelEischer MichaelEischer MichaelEischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Bidirectional sync & deleted Events lead to "zombie" events
3 participants
@HannesHil @MichaelEischer @alxndr13