Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elements/ino-nav-drawer): reinit listeners properly when switching between variants #1252

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

BenPag
Copy link
Collaborator

@BenPag BenPag commented Feb 13, 2024

Closes #1204

Proposed Changes

  • reinitialize instance of MDCDrawer on variant change

@BenPag BenPag requested a review from janivo February 19, 2024 09:38
Copy link
Collaborator

@janivo janivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Can we name it a bit more explicit? Like reinitializeAfterVariantChange? Also please add a code comment on why we need this flag so we dont get confused in the future.

@janivo janivo changed the title fix(elements/ino-nav-drawer): reinitialize MDCDrawer on variant change fix(elements/ino-nav-drawer): reinit listeners properly when switching between variants Feb 19, 2024
@janivo janivo merged commit 4198687 into master Feb 19, 2024
5 checks passed
@janivo janivo deleted the elements#1204_fix-behavior-switching-between-variants branch February 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ino-drawer: Fix Behavior After Switching Between Docked and Mobile Variants
2 participants