Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: summerize all migration files #4148

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mateo-ivc
Copy link
Collaborator

Description

Summarized all migrations into the initial sql file

Changelog

  • Removed all migration files
  • Added the migrations into initial_schema.up.sql
  • Updated initial_schema.down.sql

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Copy link

octomind-dev bot commented May 16, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: b116466

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4148.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-b116466

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-b116466

Copy link

octomind-dev bot commented May 17, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: b116466

Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a particular reason the migration files aren't needed anymore? isn't this nice to have in the case one needs to revert to the previous/different state of the db, e.g. in case of another branch?

@mateo-ivc mateo-ivc self-assigned this May 23, 2024
@mateo-ivc
Copy link
Collaborator Author

mateo-ivc commented May 23, 2024

is there a particular reason the migration files aren't needed anymore? isn't this nice to have in the case one needs to revert to the previous/different state of the db, e.g. in case of another branch?

Maybe because it were so many that now was a nice point to summarize them before it gets to chaotic.
Maybe @brandstetterm can say more about it.

@brandstetterm
Copy link
Collaborator

is there a particular reason the migration files aren't needed anymore? isn't this nice to have in the case one needs to revert to the previous/different state of the db, e.g. in case of another branch?

Maybe because it were so many that now was a nice point to summarize them before it gets to chaotic. Mayber @brandstetterm can say more about it.

I thought it's quite hard finding out the current blueprint of our database with so many migration script files. But if there's a good reason why you shouldn't combine them into one (maybe because the project is still ongoing?), we can of course keep them.

@Schwehn42
Copy link
Collaborator

@brandstetterm @mateo-ivc well personally, I don't mind since I usually flatten the DB anyways before switching to a new feature branch 😂

But concerning maintainability I would like to hear @Lennart01's opinion on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants