New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature lint php #19

Merged

Chrico merged 20 commits into main from 18_feature_lint_php

Oct 14, 2022

Member

Chrico commented Oct 12, 2022

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

See #18

Chrico added 2 commits

October 12, 2022 09:47


          init commit of lint-php.yml

c4dde15


          php.md // move "ENV_VARS" in code examples to secrets:

3ff61ec

Chrico requested a review from tyrann0us

October 12, 2022 08:01

Chrico linked an issue

that may be closed by this pull request

[Feature Request]: New reusable workflow "compatibility check PHP" #18

Closed

1 task

tyrann0us requested changes

View reviewed changes

Member

tyrann0us left a comment

A couple of things regarding the LINT_ARGS that could be improved. Also, do we really need additional environment variables in this workflow?

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

docs/php.md Outdated Show resolved Hide resolved

docs/php.md Outdated Show resolved Hide resolved

docs/php.md Outdated Show resolved Hide resolved

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

docs/php.md Outdated Show resolved Hide resolved

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

Chrico and others added 10 commits

October 12, 2022 15:15


          Update .github/workflows/lint-php.yml

e812665

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update .github/workflows/lint-php.yml

861a5e2

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update .github/workflows/lint-php.yml

6a1a79f

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update docs/php.md

ec50e66

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update docs/php.md

c87102a

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update docs/php.md

81cf3e4

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update .github/workflows/lint-php.yml

3fa4f8e

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update docs/php.md

0b30d66

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update .github/workflows/lint-php.yml

628aee6

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          Update .github/workflows/lint-php.yml

4a998f7

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>

Chrico commented

View reviewed changes

.github/workflows/lint-php.yml Show resolved Hide resolved

Chrico and others added 3 commits

October 12, 2022 15:18


          php.md // Lint PHP uses PHP 8.0 as default

0ad6602


          Update docs/php.md

f350b39

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>


          lint-php.yml // remove unused ENV_VARS from workflow.

bb95cbc

Chrico self-assigned this

Chrico added the enhancement label

Chrico added this to the The Nightmare Before Christmas milestone

tyrann0us approved these changes

View reviewed changes

Member

tyrann0us left a comment

LGTM. Thanks for taking care of it!

tyrann0us requested a review from gmazzap

October 12, 2022 13:33


          lint-php.yml // disable coverage on setup-php

5a2102d

Chrico mentioned this pull request

[Feature Request]: Disable coverage where applicable #7

Closed

1 task

gmazzap reviewed

View reviewed changes

docs/php.md Outdated Show resolved Hide resolved

docs/php.md Show resolved Hide resolved

docs/php.md Show resolved Hide resolved

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

docs/php.md Show resolved Hide resolved

.github/workflows/lint-php.yml Show resolved Hide resolved

.github/workflows/lint-php.yml Show resolved Hide resolved

.github/workflows/lint-php.yml Show resolved Hide resolved


          lint-php.yml // add new input "COMPOSER_DEPS_INSTALL" which is by def…

8d327b6

…ault "no".

tyrann0us mentioned this pull request

[Feature Request] Use GitHub Annotation output when run in PR, regular output otherwise #22

Open

tyrann0us reviewed

View reviewed changes

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved

.github/workflows/lint-php.yml Show resolved Hide resolved

Chrico and others added 2 commits

October 14, 2022 08:58


          lint-php.yml // switch type for COMPOSER_DEPS_INSTALL to boolean.

78e97fa


          Update .github/workflows/lint-php.yml

abb543d

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>

tyrann0us reviewed

View reviewed changes

docs/php.md Outdated Show resolved Hide resolved


          Match description in documentation with workflow

455c70b

tyrann0us approved these changes

View reviewed changes

Member

tyrann0us left a comment

Thanks!

Chrico merged commit b6289f2 into main

Chrico deleted the 18_feature_lint_php branch

October 14, 2022 08:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels