Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it build with ghc-9.6 #104

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Make it build with ghc-9.6 #104

merged 2 commits into from
Jul 13, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Jul 6, 2023 •
edited
Loading

Changelog

- description: |
    Make it build with ghc-9.6
  compatibility: no-api-changes
  type: feature

@erikd erikd mentioned this pull request Jul 6, 2023
Closed
@erikd erikd marked this pull request as draft July 6, 2023 08:15
@erikd
Copy link
Contributor Author

erikd commented Jul 6, 2023 •
edited
Loading

Sorry, @carbolymer, I meant to mark this as draft. Its not ready yet.

First and foremost I need to get rid of the SRPs.

@erikd erikd force-pushed the erikd/ghc-9.6 branch 3 times, most recently from e29c064 to f9ca6a3 Compare July 11, 2023 04:30
@erikd erikd marked this pull request as ready for review July 11, 2023 04:46
erikd
erikd commented Jul 11, 2023
View reviewed changes
cabal.project
-- of `cardano-ledger-byron-test` also do not permit the version of `base` that `ghc-9.6`
-- provides.
, *:base

-- IMPORTANT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would not want to merge this to master with this allow-newer but in this case its for a very specific and narrow reason.

@newhoggy newhoggy force-pushed the erikd/ghc-9.6 branch 5 times, most recently from 93db333 to f9ca6a3 Compare July 11, 2023 14:36
@erikd erikd force-pushed the erikd/ghc-9.6 branch 3 times, most recently from cb5ee92 to 3ea32e4 Compare July 12, 2023 22:40
@newhoggy
Copy link
Collaborator

Shouldn't the haskell.yml also be updated to have ghc-8.6 in the build matrix?

@erikd erikd requested a review from a team as a code owner July 13, 2023 09:16
@newhoggy newhoggy enabled auto-merge July 13, 2023 09:20
@newhoggy newhoggy added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit d7ef2c8 Jul 13, 2023
@newhoggy newhoggy deleted the erikd/ghc-9.6 branch July 13, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@carbolymer carbolymer carbolymer approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikd @newhoggy @carbolymer