Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export withShelleyBasedEraConstraintsForLedger #108

Merged

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jul 7, 2023

Changelog

- description: |
    Export `withShelleyBasedEraConstraintsForLedger`
    Use the ^>= version range operator for ledger and consensus libraries to avoid breaking changes affecting builds.
  compatibility: compatible
  type: feature

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy changed the title Export withShelleyBasedEraConstraintsForLedger Export withShelleyBasedEraConstraintsForLedger Jul 7, 2023
@newhoggy newhoggy marked this pull request as ready for review July 7, 2023 16:22
@newhoggy newhoggy force-pushed the newhoggy/export-withShelleyBasedEraConstraintsForLedger branch 2 times, most recently from afb2053 to ab6b604 Compare July 7, 2023 16:52
@newhoggy newhoggy force-pushed the newhoggy/export-withShelleyBasedEraConstraintsForLedger branch from ab6b604 to f4b8dbe Compare July 8, 2023 04:57
@newhoggy newhoggy added this pull request to the merge queue Jul 8, 2023
Merged via the queue into main with commit f8c680e Jul 8, 2023
17 checks passed
@newhoggy newhoggy deleted the newhoggy/export-withShelleyBasedEraConstraintsForLedger branch July 8, 2023 05:31
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
Fix build issues related to GHC-version dependend constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants