Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose toShelleyPoolParams for conway integration #134

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jul 24, 2023

Changelog

- description: |
    Expose `toShelleyPoolParams` for Conway integration
  compatibility: compatible
  type: feature

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 changed the title Expose more for conway integration Expose toShelleyPoolParams for conway integration Jul 24, 2023
@newhoggy newhoggy added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit 877c392 Jul 25, 2023
18 of 21 checks passed
@newhoggy newhoggy deleted the jordan/expose-more-for-conway branch July 25, 2023 07:16
@Jimbo4350 Jimbo4350 restored the jordan/expose-more-for-conway branch July 25, 2023 16:02
@Jimbo4350 Jimbo4350 deleted the jordan/expose-more-for-conway branch October 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants