-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide additional constraints in shelleyBasedEraConstraints
#143
Provide additional constraints in shelleyBasedEraConstraints
#143
Conversation
shelleyBasedEraConstraints
…s.Constraints. This allows more constraints to be added without creating cycling dependencies
4803f72
to
048b145
Compare
e00e53b
to
ebc3945
Compare
@@ -831,5 +827,5 @@ conwayCertificateConstraints | |||
, Ledger.TxCert (ShelleyLedgerEra era) ~ Ledger.ConwayTxCert (ShelleyLedgerEra era) | |||
) => a) | |||
-> a | |||
conwayCertificateConstraints ConwayEraOnwardsConway f = f | |||
conwayCertificateConstraints = conwayEraOnwardsConstraints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use a deprecation pragma. Not vital to do in this PR but when we want to remove it, let's use a deprecation pragma first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Soft deprecation so as to be not disruptive to work. Actual deprecation later.
ebc3945
to
9dc97c3
Compare
9dc97c3
to
e4f4ee6
Compare
…BabbageEra and BabbageEraOnwards.
e4f4ee6
to
f3d05c8
Compare
Changelog
Context
Checklist
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.