Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide additional constraints in shelleyBasedEraConstraints #143

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jul 27, 2023

Changelog

- description: |
    Provide additional constraints in `shelleyBasedEraConstraints`.  This will obsolete the following:
    - `obtainEraCryptoConstraints`
    - `obtainCryptoConstraints`
    - `obtainEraPParamsConstraint`
    - `obtainSafeToHashConstraint`
    Also provide additional constraints in `conwayEraOnwardsConstraints` and `shelleyToBabbageEraConstraints`
  compatibility: compatible
  type: feature

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy changed the title Provide additional constraints in shelleyBasedEraConstraints Provide additional constraints in shelleyBasedEraConstraints Jul 27, 2023
@newhoggy newhoggy marked this pull request as ready for review July 27, 2023 08:17
@newhoggy newhoggy added this pull request to the merge queue Jul 27, 2023
@newhoggy newhoggy removed this pull request from the merge queue due to a manual request Jul 27, 2023
…s.Constraints. This allows more constraints to be added without creating cycling dependencies
@newhoggy newhoggy force-pushed the newhoggy/provide-additional-constraints-in-shelleyBasedEraConstraints branch from 4803f72 to 048b145 Compare July 27, 2023 13:25
@newhoggy newhoggy force-pushed the newhoggy/provide-additional-constraints-in-shelleyBasedEraConstraints branch 2 times, most recently from e00e53b to ebc3945 Compare July 27, 2023 13:56
@@ -831,5 +827,5 @@ conwayCertificateConstraints
, Ledger.TxCert (ShelleyLedgerEra era) ~ Ledger.ConwayTxCert (ShelleyLedgerEra era)
) => a)
-> a
conwayCertificateConstraints ConwayEraOnwardsConway f = f
conwayCertificateConstraints = conwayEraOnwardsConstraints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use a deprecation pragma. Not vital to do in this PR but when we want to remove it, let's use a deprecation pragma first.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Soft deprecation so as to be not disruptive to work. Actual deprecation later.

@newhoggy newhoggy force-pushed the newhoggy/provide-additional-constraints-in-shelleyBasedEraConstraints branch from ebc3945 to 9dc97c3 Compare July 27, 2023 14:10
@newhoggy newhoggy requested a review from Jimbo4350 July 27, 2023 14:11
@newhoggy newhoggy force-pushed the newhoggy/provide-additional-constraints-in-shelleyBasedEraConstraints branch from 9dc97c3 to e4f4ee6 Compare July 27, 2023 14:22
@newhoggy newhoggy enabled auto-merge July 27, 2023 14:24
@newhoggy newhoggy force-pushed the newhoggy/provide-additional-constraints-in-shelleyBasedEraConstraints branch from e4f4ee6 to f3d05c8 Compare July 27, 2023 14:38
@newhoggy newhoggy added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit b78a171 Jul 27, 2023
18 checks passed
@newhoggy newhoggy deleted the newhoggy/provide-additional-constraints-in-shelleyBasedEraConstraints branch July 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants