Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ErrorSpec check for all constructors, move golden tests together #18

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 24, 2023

Description

This is a follow-up PR after #9 (comment)

Changelog

- description: |
    Make `ErrorSpec` check for all constructors. Move golden tests together.
  compatibility: no-api-changes
  type: test

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/feat/errorspec-checkfor-constructor-count branch 2 times, most recently from d4702f5 to 8a990bf Compare May 31, 2023 16:03
@carbolymer carbolymer changed the title Make ErrorSpec check for constructor names count Make ErrorSpec check for all constructors, move golden tests together May 31, 2023
@carbolymer carbolymer marked this pull request as ready for review May 31, 2023 16:05
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment regarding the use of head.

H.property $ do
test_roundtrip_HashableScriptData_JSON :: TestTree
test_roundtrip_HashableScriptData_JSON =
testPropertyNamed "roundtrip HashableScriptData" "roundtrip HashableScriptData" . H.property $ do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can eventually abstract this as a function: testPropertyNamed "roundtrip HashableScriptData" "roundtrip HashableScriptData" . H.property

@newhoggy
Copy link
Collaborator

newhoggy commented Jun 1, 2023

There's a build failure.

@carbolymer carbolymer force-pushed the mgalazyn/feat/errorspec-checkfor-constructor-count branch 3 times, most recently from 222a3e0 to 7c2ba0f Compare June 1, 2023 09:41
@carbolymer carbolymer force-pushed the mgalazyn/feat/errorspec-checkfor-constructor-count branch from 7c2ba0f to 107b67b Compare June 1, 2023 10:27
@carbolymer carbolymer added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit 6f3ce02 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants