Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consensus governance queries #196

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 17, 2023

Changelog

- description: |
    Expose following queries from consensus:
      - GetGovState
      - GetDRepState
      - GetDRepStakeDistr
      - GetCommitteeState
      - GetConstitution
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Implement consensus queries, similarly to: IntersectMBO/cardano-ledger#3648

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/add-governance-queries branch from 50b3138 to 256ec0c Compare August 18, 2023 09:53
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-governance-queries branch 4 times, most recently from 907f360 to 95b299d Compare August 18, 2023 19:28
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-governance-queries branch 5 times, most recently from eddadf0 to e6c5d99 Compare August 22, 2023 13:53
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-governance-queries branch from e6c5d99 to ab6b1ed Compare August 22, 2023 14:11
@carbolymer carbolymer marked this pull request as ready for review August 22, 2023 14:14
@Jimbo4350 Jimbo4350 self-requested a review August 22, 2023 16:16
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-governance-queries branch 5 times, most recently from 6c22965 to ff4ddf0 Compare August 23, 2023 08:28
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-governance-queries branch from ff4ddf0 to 3f1a9e7 Compare August 23, 2023 08:29
@carbolymer carbolymer added this pull request to the merge queue Aug 23, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Aug 23, 2023
@carbolymer carbolymer merged commit 6dea2b6 into main Aug 23, 2023
19 of 20 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/add-governance-queries branch August 23, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants