Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functions emptyVotingProcedures, singletonVotingProcedures and mergeVotingProcedures #208

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

newhoggy
Copy link
Collaborator

Changelog

- description: |
    New functions `emptyVotingProcedures`, `singletonVotingProcedures` and `mergeVotingProcedures`
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Useful functions for VotingProcedures.

For use cases, see: IntersectMBO/cardano-cli#203

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 24, 2023 13:17
@newhoggy newhoggy force-pushed the newhoggy/new-VotingProcedures-functions branch 2 times, most recently from 0029e71 to 4167c39 Compare August 24, 2023 14:20
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss mergeVotingProcedures

@newhoggy newhoggy force-pushed the newhoggy/new-VotingProcedures-functions branch from 4167c39 to ea0fac5 Compare August 24, 2023 15:13
@newhoggy
Copy link
Collaborator Author

Added unsafe prefix and TODO to cleanup merge function later.

@newhoggy newhoggy enabled auto-merge August 24, 2023 15:13
@newhoggy newhoggy force-pushed the newhoggy/new-VotingProcedures-functions branch from ea0fac5 to c4556d4 Compare August 25, 2023 02:13
@newhoggy newhoggy force-pushed the newhoggy/new-VotingProcedures-functions branch from c4556d4 to e945fc5 Compare August 25, 2023 02:14
@newhoggy newhoggy added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit d37da9c Aug 25, 2023
@newhoggy newhoggy deleted the newhoggy/new-VotingProcedures-functions branch August 25, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants