Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use injective type families to improve type inference #210

Merged

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Aug 24, 2023

Changelog

- description: |
    Use injective type families to improve type inference
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Without injective type families, Haskell could not infer the return type from the argument type in the following code:

foo :: LedgerType (ShelleyLedgerEra era) -> ReturnType era

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 24, 2023 14:16
@newhoggy newhoggy force-pushed the newhoggy/use-inject-type-families-to-improve-type-inference branch from ccca3c0 to ed19aeb Compare August 24, 2023 14:16
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@newhoggy newhoggy added this pull request to the merge queue Aug 24, 2023
@newhoggy newhoggy changed the title Use inject type families to improve type inference Use injective type families to improve type inference Aug 24, 2023
Merged via the queue into main with commit 3c4a5ff Aug 24, 2023
22 checks passed
@newhoggy newhoggy deleted the newhoggy/use-inject-type-families-to-improve-type-inference branch August 24, 2023 15:48
newhoggy added a commit that referenced this pull request Mar 11, 2024
…ano-api-8.17.0.0

Upgrade to `cardano-api-8.17.0.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants