Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ProtocolParameters usage with ledger's PParams #214

Merged
merged 6 commits into from
Aug 28, 2023

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 24, 2023

Changelog

- description: |
    Replace ProtocolParameters usage with ledger's PParams 
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 changed the title Replace ProtocolParameters usage in GenesisParamters with ledger's PParams Replace ProtocolParameters usage with ledger's PParams Aug 25, 2023
@Jimbo4350 Jimbo4350 force-pushed the jordan/replace-protocol-parameters-in-genesis branch 2 times, most recently from fc816be to 5534b53 Compare August 25, 2023 19:18
@Jimbo4350 Jimbo4350 changed the title Replace ProtocolParameters usage with ledger's PParams WIP: Replace ProtocolParameters usage with ledger's PParams Aug 26, 2023
@Jimbo4350 Jimbo4350 force-pushed the jordan/replace-protocol-parameters-in-genesis branch 3 times, most recently from 9770e22 to 7d37586 Compare August 28, 2023 14:07
@Jimbo4350 Jimbo4350 changed the title WIP: Replace ProtocolParameters usage with ledger's PParams Replace ProtocolParameters usage with ledger's PParams Aug 28, 2023
@Jimbo4350 Jimbo4350 force-pushed the jordan/replace-protocol-parameters-in-genesis branch from 7d37586 to d7efc97 Compare August 28, 2023 18:19
@Jimbo4350 Jimbo4350 force-pushed the jordan/replace-protocol-parameters-in-genesis branch from d7efc97 to f261909 Compare August 28, 2023 19:01
@Jimbo4350 Jimbo4350 enabled auto-merge August 28, 2023 19:04
@Jimbo4350 Jimbo4350 disabled auto-merge August 28, 2023 19:07
@newhoggy newhoggy added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 99d4557 Aug 28, 2023
@newhoggy newhoggy deleted the jordan/replace-protocol-parameters-in-genesis branch August 28, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants