Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DRep Stake and DRep Stake queries for empty lists #245

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 14, 2023

Changelog

- description: |
    Fix DRep Stake and DRep Stake queries for empty lists
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Ledger's queryDRepStakeDistr and queryDRepState do return a full list of DRep stake distributions and states actually. This PR fixes API queries using those.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The cli options for these queries also need to be updated.

@carbolymer carbolymer added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit eabf9fc Sep 14, 2023
@carbolymer carbolymer deleted the mgalazyn/fix/execute-drep-queries-for-empty-dreps-list branch September 14, 2023 14:18
newhoggy added a commit that referenced this pull request Mar 11, 2024
…nt-constraints-only-on-ghc-8.10.7

Disable `redundant-constraints` warning only on `ghc-8.10.7`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants