Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cardano-api:internal component public #26

Merged
merged 1 commit into from
May 25, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented May 25, 2023

Changelog

- description: |
    Make `cardano-api:internal` component public
  compatibility: compatible
  type: feature

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/make-cardano-api-internal-public branch 2 times, most recently from c73ecd4 to 733a480 Compare May 25, 2023 06:02
@newhoggy newhoggy force-pushed the newhoggy/make-cardano-api-internal-public branch from 733a480 to e6f6f9c Compare May 25, 2023 06:06
@newhoggy newhoggy added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit 0be9247 May 25, 2023
14 checks passed
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant